linux-kernel - Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79739b73f77a124cafa056e56f57c450@suse.de>
Date:   Wed, 16 Sep 2020 20:12:31 +0200
From:   osalvador@...e.de
To:     Aristeu Rozanski <aris@...vo.org>
Cc:     naoya.horiguchi@....com, akpm@...ux-foundation.org,
        mhocko@...nel.org, tony.luck@...el.com, cai@....pw,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups

On 2020-09-16 19:58, Aristeu Rozanski wrote:
> On Wed, Sep 16, 2020 at 06:34:52PM +0200, osalvador@...e.de wrote:
>> Fat fingers, sorry:
>> 
>> Ok, this is something different.
>> The race you saw previously is kinda normal as there is a race window
>> between spotting a freepage and taking it off the buddy freelists.
>> The retry patch should help there.
>> 
>> The issue you are seeing right here is due to the call to
>> page_handle_poison in __soft_offline_page being wrong, as we pass
>> hugepage_or_freepage = true inconditionally, which is wrong.
>> I think it was caused during rebasing.
>> 
>> Should be:
> 
> Tests passed with this patch on top of others.
> Thanks!

Thanks for giving it a shot!
I will be sending patches tomorrow morning.

Thanks