linux-kernel - Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200916142816.GA2979962@kroah.com>
Date:   Wed, 16 Sep 2020 16:28:16 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     吳昊澄 Ricky <ricky_wu@...ltek.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "rui_feng@...lsil.com.cn" <rui_feng@...lsil.com.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "puranjay12@...il.com" <puranjay12@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "vailbhavgupta40@...il.com" <vailbhavgupta40@...il.com>
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
 driving parameter

On Wed, Sep 16, 2020 at 08:32:26AM -0500, Bjorn Helgaas wrote:
> > So is it ok to take this patch now, or does it need to be changed any?
> 
> Yes, it's OK with me if you take this patch.
> 
> The ASPM hardware feature is designed to work without any driver
> support.  It does need to be configured, which involves both the
> device and the upstream bridge, so it should be done by the BIOS or
> the PCI core.  There are a few drivers (amdgpu, radeon, hfi1, e1000e,
> iwlegacy, ath10k, ath9k, mt76, rtlwifi, rtw88, and these rts
> cardreader drivers) that do it themselves, incorrectly.
> 
> But this particular patch only *reads* the ASPM control registers,
> without writing them, so it shouldn't make anything worse.

Ok, thanks for the review, now queued up.

greg k-h