linux-kernel - Re: [PATCH v3 01/10] dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160028536666.4188128.14311541474912461984@swboyd.mtv.corp.google.com>
Date:   Wed, 16 Sep 2020 12:42:46 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>,
        Tanmay Shah <tanmay@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        Sandeep Maheswaram <sanm@...eaurora.org>,
        Douglas Anderson <dianders@...omium.org>,
        Sean Paul <seanpaul@...omium.org>,
        Jonathan Marek <jonathan@...ek.ca>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        devicetree@...r.kernel.org, Rob Clark <robdclark@...omium.org>
Subject: Re: [PATCH v3 01/10] dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information

Quoting Rob Herring (2020-09-15 13:24:32)
> On Wed, Sep 09, 2020 at 11:48:21PM -0700, Stephen Boyd wrote:
> > Quoting Stephen Boyd (2020-09-09 17:48:53)
> > > This binding only describes the USB phy inside the USB3 + DP "combo"
> > > phy. Add information for the DP phy and describe the sub-nodes that
> > > represent the DP and USB3 phys that exist inside the combo wrapper.
> > > Remove reg-names from required properties because it isn't required nor
> > > used by the kernel driver.
> > > 
> > > Cc: Jeykumar Sankaran <jsanka@...eaurora.org>
> > > Cc: Chandan Uddaraju <chandanu@...eaurora.org>
> > > Cc: Vara Reddy <varar@...eaurora.org>
> > > Cc: Tanmay Shah <tanmay@...eaurora.org>
> > > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > > Cc: Manu Gautam <mgautam@...eaurora.org>
> > > Cc: Sandeep Maheswaram <sanm@...eaurora.org>
> > > Cc: Douglas Anderson <dianders@...omium.org>
> > > Cc: Sean Paul <seanpaul@...omium.org>
> > > Cc: Jonathan Marek <jonathan@...ek.ca>
> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > > Cc: <devicetree@...r.kernel.org>
> > > Cc: Rob Herring <robh+dt@...nel.org>
> > > Cc: Rob Clark <robdclark@...omium.org>
> > > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > > ---
> > >  .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml    | 91 +++++++++++++++++--
> > >  1 file changed, 81 insertions(+), 10 deletions(-)
> > 
> > I noticed that I didn't document the new compatible string I'm using,
> > qcom,sc7180-qmp-usb3-dp-phy, ugh.
> > 
> > Should I copy the whole file over and make a new document for the new
> > compatible string? That feels like the better solution vs. making this
> > binding have min/max stuff where it fails to enforce the DP part of the
> > phy. We can delete this binding once the kernel tree isn't using it,
> > right?
> 
> It generally depends on how much if/then schema you have (or should 
> have) vs. how much is common, but it's a judgement call. It looks 
> like you are just extending the binding for the most part. If there's 
> dtb warnings until the existing stuff gets updated, that's fine.
> 

Ok. I'll just add in the extra compatible and then we can drop the older
ones at some point.