linux-kernel - Re: mmotm 2020-09-15-20-44 uploaded (security/smack/smack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <458c2df8-1db6-4c94-a694-053324e3e76f@infradead.org>
Date:   Wed, 16 Sep 2020 08:19:02 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     akpm@...ux-foundation.org, broonie@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au,
        Casey Schaufler <casey@...aufler-ca.com>,
        linux-security-module <linux-security-module@...r.kernel.org>
Subject: Re: mmotm 2020-09-15-20-44 uploaded (security/smack/smack_lsm.c)

On 9/15/20 8:45 PM, akpm@...ux-foundation.org wrote:
> The mm-of-the-moment snapshot 2020-09-15-20-44 has been uploaded to
> 
>    http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.
> 
> You will need quilt to apply these patches to the latest Linus release (5.x
> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> http://ozlabs.org/~akpm/mmotm/series
> 

on x86_64:
# CONFIG_NETWORK_SECMARK is not set

  CC      security/smack/smack_lsm.o
In file included from ../include/asm-generic/bug.h:5:0,
                 from ../arch/x86/include/asm/bug.h:93,
                 from ../include/linux/bug.h:5,
                 from ../include/linux/mmdebug.h:5,
                 from ../include/linux/gfp.h:5,
                 from ../include/linux/slab.h:15,
                 from ../include/linux/xattr.h:15,
                 from ../security/smack/smack_lsm.c:18:
../security/smack/smack_lsm.c: In function ‘smack_from_skb’:
../security/smack/smack_lsm.c:3843:26: error: ‘struct sk_buff’ has no member named ‘secmark’; did you mean ‘mark’?
  if (skb == NULL || skb->secmark == 0)
                          ^
../include/linux/compiler.h:58:52: note: in definition of macro ‘__trace_if_var’
 #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                    ^~~~
../security/smack/smack_lsm.c:3843:2: note: in expansion of macro ‘if’
  if (skb == NULL || skb->secmark == 0)
  ^~
../security/smack/smack_lsm.c:3843:26: error: ‘struct sk_buff’ has no member named ‘secmark’; did you mean ‘mark’?
  if (skb == NULL || skb->secmark == 0)
                          ^
../include/linux/compiler.h:58:61: note: in definition of macro ‘__trace_if_var’
 #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                             ^~~~
../security/smack/smack_lsm.c:3843:2: note: in expansion of macro ‘if’
  if (skb == NULL || skb->secmark == 0)
  ^~
../security/smack/smack_lsm.c:3843:26: error: ‘struct sk_buff’ has no member named ‘secmark’; did you mean ‘mark’?
  if (skb == NULL || skb->secmark == 0)
                          ^
../include/linux/compiler.h:69:3: note: in definition of macro ‘__trace_if_value’
  (cond) ?     \
   ^~~~
../include/linux/compiler.h:56:28: note: in expansion of macro ‘__trace_if_var’
 #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
                            ^~~~~~~~~~~~~~
../security/smack/smack_lsm.c:3843:2: note: in expansion of macro ‘if’
  if (skb == NULL || skb->secmark == 0)
  ^~
../security/smack/smack_lsm.c:3846:31: error: ‘struct sk_buff’ has no member named ‘secmark’; did you mean ‘mark’?
  return smack_from_secid(skb->secmark);
                               ^~~~~~~
                               mark
../security/smack/smack_lsm.c:3847:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^


Full randconfig file is attached.


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>

View attachment "config-r5046" of type "text/plain" (159293 bytes)