linux-kernel - Re: [PATCH -next] fpga: dfl: Make m10_n3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200916161040.GA1066896@epycbox.lan>
Date:   Wed, 16 Sep 2020 09:10:40 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     hao.wu@...el.com, trix@...hat.com, mdf@...nel.org,
        yilun.xu@...el.com, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] fpga: dfl: Make m10_n3000_info static

Hi Yue,

On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/fpga/dfl-n3000-nios.c:392:23: warning:
>  symbol 'm10_n3000_info' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/fpga/dfl-n3000-nios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c
> index 5088f8f0e0cd..686813b59d33 100644
> --- a/drivers/fpga/dfl-n3000-nios.c
> +++ b/drivers/fpga/dfl-n3000-nios.c
> @@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns)
>  	return ret;
>  }
>  
> -struct spi_board_info m10_n3000_info = {
> +static struct spi_board_info m10_n3000_info = {
>  	.modalias = "m10-n3000",
>  	.max_speed_hz = 12500000,
>  	.bus_num = 0,
> -- 
> 2.17.1
> 
Can you resend this with a [PATCH v2] or [PATCH v2 next], neither
lore nor patchwork picks it up in its current form.

This'll make sure it doesn't get lost.

While at it could you change the first line to:

"fpga: dfl: n3000-nios: Make m10_n3000_info static"

Thanks for the patch,
Moritz