linux-kernel - Re: [PATCH net-next] netdev: Remove unused funtions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37c7b88261ad99c038764256a6e4d1ba995d3cdd.camel@kernel.org>
Date:   Wed, 16 Sep 2020 13:32:38 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] netdev: Remove unused funtions

On Wed, 2020-09-16 at 22:18 +0800, YueHaibing wrote:
> There is no callers in tree, so can remove it.
> 

You have a typo in the patch title:
funtions -> functions

> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Please feel free to add my R.B tag after on V2.
Reviewed-by: Saeed Mahameed <saeedm@...dia.com>

And by the way, you have 3 patches doing similar things, please
consider submitting them as one series on V2:

$ git format-patch --cover-letter \
    --subject-prefix="PATCH net-next"  HEAD~3.. -o patches/ 


> ---
>  include/linux/netdevice.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 157e0242e9ee..909b1fbb0481 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -4677,16 +4677,6 @@ int netdev_class_create_file_ns(const struct
> class_attribute *class_attr,
>  void netdev_class_remove_file_ns(const struct class_attribute
> *class_attr,
>  				 const void *ns);
>  
> -static inline int netdev_class_create_file(const struct
> class_attribute *class_attr)
> -{
> -	return netdev_class_create_file_ns(class_attr, NULL);
> -}
> -
> -static inline void netdev_class_remove_file(const struct
> class_attribute *class_attr)
> -{
> -	netdev_class_remove_file_ns(class_attr, NULL);
> -}
> -
>  extern const struct kobj_ns_type_operations net_ns_type_operations;
>  
>  const char *netdev_drivername(const struct net_device *dev);