linux-kernel - Re: [PATCH] clk: bcm: fix kconfig dependency warning for CLK_BCM2711

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200915140730.37n4q6y5si3evdlx@gilmour.lan>
Date:   Tue, 15 Sep 2020 16:07:30 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc:     mturquette@...libre.com, sboyd@...nel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] clk: bcm: fix kconfig dependency warning for
 CLK_BCM2711_DVP

Hi,

On Tue, Sep 15, 2020 at 01:37:50PM +0300, Necip Fazil Yildiran wrote:
> When CLK_BCM2711_DVP is enabled and RESET_CONTROLLER is disabled, it
> results in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for RESET_SIMPLE
>   Depends on [n]: RESET_CONTROLLER [=n]
>   Selected by [y]:
>   - CLK_BCM2711_DVP [=y] && (ARCH_BCM2835 [=n] || COMPILE_TEST [=y]) && COMMON_CLK [=y]
> 
> The reason is that CLK_BCM2711_DVP selects RESET_SIMPLE without depending
> on or selecting RESET_CONTROLLER while RESET_SIMPLE is subordinate to
> RESET_CONTROLLER.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: 1bc95972715a ("clk: bcm: Add BCM2711 DVP driver")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>

A similar patch has already been sent (and merged):
https://lore.kernel.org/linux-clk/20200903082636.3844629-1-maxime@cerno.tech/

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)