lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 16 Sep 2020 15:13:42 +0200 (CEST)
From:   Miroslav Benes <>
To:     Mark Brown <>
cc:     Catalin Marinas <>,
        Will Deacon <>,
        Mark Rutland <>,
        Vasily Gorbik <>,
        Heiko Carstens <>,
        Borislav Petkov <>,
        Thomas Gleixner <>,
        "H . Peter Anvin" <>,
        Christian Borntraeger <>,
        Ingo Molnar <>,
        Jiri Slaby <>,,,,
Subject: Re: [PATCH v3 0/3] arm64: Convert to ARCH_STACKWALK

On Mon, 14 Sep 2020, Mark Brown wrote:

> This series updates the arm64 stacktrace code to use the newer and much
> simpler arch_stack_walk() interface, the main benefit being a single
> entry point to the arch code with no need for the arch code to worry
> about skipping frames. Along the way I noticed that the reliable
> parameter to the arch_stack_walk() callback appears to be redundant
> so there's also a patch here removing that from the existing code to
> simplify the interface.
> This is preparatory work for implementing reliable stack trace for
> arm64.
> v3:
>  - Rebase onto v5.9-rc3.
>  - Fix handling of task == current.
>  - Flip the sense of the walk_stackframe() callback.
> v2:
>  - Rebase onto v5.9-rc1.
> Mark Brown (3):
>   stacktrace: Remove reliable argument from arch_stack_walk() callback
>   arm64: stacktrace: Make stack walk callback consistent with generic
>     code
>   arm64: stacktrace: Convert to ARCH_STACKWALK

The patches look good to me.

Reviewed-by: Miroslav Benes <>


Powered by blists - more mailing lists