lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 16 Sep 2020 15:51:11 +0100
From:   Catalin Marinas <>
To:     Lorenzo Pieralisi <>
        George Cherian <>,
        Arnd Bergmann <>, Will Deacon <>,
        Bjorn Helgaas <>,
        Yang Yingliang <>,,,,
        "David S. Miller" <>
Subject: Re: [PATCH v2 3/3] asm-generic/io.h: Fix !CONFIG_GENERIC_IOMAP
 pci_iounmap() implementation

On Wed, Sep 16, 2020 at 12:06:58PM +0100, Lorenzo Pieralisi wrote:
> For arches that do not select CONFIG_GENERIC_IOMAP, the current
> pci_iounmap() function does nothing causing obvious memory leaks
> for mapped regions that are backed by MMIO physical space.
> In order to detect if a mapped pointer is IO vs MMIO, a check must made
> available to the pci_iounmap() function so that it can actually detect
> whether the pointer has to be unmapped.
> a mapped port is detected using an ioport_map() stub defined in
> asm-generic/io.h.
> Use the same logic to implement a stub (ie __pci_ioport_unmap()) that
> detects if the passed in pointer in pci_iounmap() is IO vs MMIO to
> iounmap conditionally and call it in pci_iounmap() fixing the issue.
> Leave __pci_ioport_unmap() as a NOP for all other config options.
> Reported-by: George Cherian <>
> Link:
> Link:
> Signed-off-by: Lorenzo Pieralisi <>
> Cc: Arnd Bergmann <>
> Cc: George Cherian <>
> Cc: Will Deacon <>
> Cc: Bjorn Helgaas <>
> Cc: Catalin Marinas <>
> Cc: Yang Yingliang <>
> ---
>  include/asm-generic/io.h | 39 +++++++++++++++++++++++++++------------
>  1 file changed, 27 insertions(+), 12 deletions(-)

This works for me. The only question I have is whether pci_iomap.h is
better than io.h for __pci_ioport_unmap(). These headers are really

Either way:

Reviewed-by: Catalin Marinas <>

Powered by blists - more mailing lists