linux-kernel - Re: [PATCH] regmap: debugfs: Duplicate name string if delaying debugfs init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200916161418.GB6374@sirena.org.uk>
Date:   Wed, 16 Sep 2020 17:14:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] regmap: debugfs: Duplicate name string if delaying
 debugfs init

On Wed, Sep 16, 2020 at 04:44:33PM +0100, Charles Keepax wrote:

> -		node->name = name;
> +		node->name = kstrdup(name, GFP_KERNEL);
> +		if (!node->name) {

Two things here - one is that this should be kstrdup_const(), the other
is that we already took a copy of the name in __regmap_init() so the
thing to do here is to change the regmap_debugfs_init() call there to
use the copy we just made rather than the copy in the config.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)