linux-kernel - Re: [PATCH] spi: xilinx: Fix info message during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 13:41:02 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Ricardo Ribalda <ribalda@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: xilinx: Fix info message during probe



On 15. 09. 20 13:29, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid
> security problems, all virtual addresses are converted to __ptrval__, so
> the message was useless/ugly:
> 
> [    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37
> 
> Use %pR instead:
> 
> [   15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...nel.org>
> ---
>  drivers/spi/spi-xilinx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 8dd2bb99cb4d..523edfdf5dcd 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		goto put_master;
>  	}
>  
> -	dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
> -		(unsigned long long)res->start, xspi->regs, xspi->irq);
> +	dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);
>  
>  	if (pdata) {
>  		for (i = 0; i < pdata->num_devices; i++)
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal