linux-kernel - RE: [PATCH 1/3] exfat: remove useless directory scan in exfat_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <015d01d68bd0$2fc6bb60$8f543220$@samsung.com>
Date:   Wed, 16 Sep 2020 11:22:12 +0900
From:   "Sungjong Seo" <sj1557.seo@...sung.com>
To:     "'Tetsuhiro Kohada'" <kohada.t2@...il.com>
Cc:     <kohada.tetsuhiro@...mitsubishielectric.co.jp>,
        <mori.takahiro@...mitsubishielectric.co.jp>,
        <motai.hirotaka@...mitsubishielectric.co.jp>,
        "'Namjae Jeon'" <namjae.jeon@...sung.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3] exfat: remove useless directory scan in
 exfat_add_entry()

> There is nothing in directory just created, so there is no need to scan.
> 
> Signed-off-by: Tetsuhiro Kohada <kohada.t2@...il.com>

Acked-by: Sungjong Seo <sj1557.seo@...sung.com>

> ---
>  fs/exfat/namei.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index
> b966b9120c9c..803748946ddb 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -530,19 +530,10 @@ static int exfat_add_entry(struct inode *inode,
> const char *path,
>  		info->size = 0;
>  		info->num_subdirs = 0;
>  	} else {
> -		int count;
> -		struct exfat_chain cdir;
> -
>  		info->attr = ATTR_SUBDIR;
>  		info->start_clu = start_clu;
>  		info->size = clu_size;
> -
> -		exfat_chain_set(&cdir, info->start_clu,
> -			EXFAT_B_TO_CLU(info->size, sbi), info->flags);
> -		count = exfat_count_dir_entries(sb, &cdir);
> -		if (count < 0)
> -			return -EIO;
> -		info->num_subdirs = count + EXFAT_MIN_SUBDIR;
> +		info->num_subdirs = EXFAT_MIN_SUBDIR;
>  	}
>  	memset(&info->crtime, 0, sizeof(info->crtime));
>  	memset(&info->mtime, 0, sizeof(info->mtime));
> --
> 2.25.1