linux-kernel - Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKRVAePsLTRzQC+5dYYYQ+x+fk8ogoME9uuobzyeJ2J-6kNHPg@mail.gmail.com>
Date:   Wed, 16 Sep 2020 10:36:48 +0800
From:   Chunxin Zang <zangchunxin@...edance.com>
To:     Chris Down <chris@...isdown.name>
Cc:     Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Muchun Song <songmuchun@...edance.com>
Subject: Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

On Wed, Sep 16, 2020 at 12:26 AM Chris Down <chris@...isdown.name> wrote:
>
> Michal Hocko writes:
> >On Tue 15-09-20 15:47:37, Chris Down wrote:
> >> zangchunxin@...edance.com writes:
> >> > +          if (signal_pending(current))
> >> > +                  return;
> >>
> >> This doesn't match your patch title, please update it. :-)
> >
> >I have to admit I have completely missed this and I think that this
> >should better be fatal_signal_pending because that would make sure that
> >the userspace will not see an incomplete operation. This is a general
> >practice for other bail outs as well.
>
> Oh sorry, to be clear, I meant the patch should match the title, not the other
> way around.

My apologies about that. In my first version of patch, it's
'fatal_signal_pending'.
But in this version, I used the wrong branch. I will update it now.

Best wishes
Chunxin