linux-kernel - Re: [PATCH -next] firmware: arm_sdei: simplify the return expression of sdei_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fdd9c4d-d957-e7d5-818d-cc9247be9dfd@redhat.com>
Date:   Wed, 16 Sep 2020 13:40:16 +1000
From:   Gavin Shan <gshan@...hat.com>
To:     Liu Shixin <liushixin2@...wei.com>,
        James Morse <james.morse@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] firmware: arm_sdei: simplify the return expression
 of sdei_device_freeze()

On 9/15/20 1:26 PM, Liu Shixin wrote:
> Simplify the return expression.
> 
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> ---

Reviewed-by: Gavin Shan <gshan@...hat.com>

>   drivers/firmware/arm_sdei.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index b4b9ce97f415..5b4c8c51cb20 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -798,16 +798,10 @@ static int sdei_device_resume(struct device *dev)
>    */
>   static int sdei_device_freeze(struct device *dev)
>   {
> -	int err;
> -
>   	/* unregister private events */
>   	cpuhp_remove_state(CPUHP_AP_ARM_SDEI_STARTING);
>   
> -	err = sdei_unregister_shared();
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return sdei_unregister_shared();
>   }
>   
>   static int sdei_device_thaw(struct device *dev)
>