linux-kernel - Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPd-VZAOcezOS5-18te6OQZ53BU24su3WmAf+=Gtt8aBtw@mail.gmail.com>
Date:   Wed, 16 Sep 2020 08:03:49 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anson Huang <anson.huang@....com>
Cc:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "oleksandr.suvorov@...adex.com" <oleksandr.suvorov@...adex.com>,
        Peng Fan <peng.fan@....com>,
        "andreas@...nade.info" <andreas@...nade.info>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "olof@...om.net" <olof@...om.net>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "prabhakar.mahadev-lad.rj@...renesas.com" 
        <prabhakar.mahadev-lad.rj@...renesas.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "lkundrak@...sk" <lkundrak@...sk>,
        "joel@....id.au" <joel@....id.au>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Leo Li <leoyang.li@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "michael@...le.cc" <michael@...le.cc>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC
 by default

On Wed, 16 Sep 2020 at 03:59, Anson Huang <anson.huang@....com> wrote:
>
> Hi, Krzysztof
>
> > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in
> > CONFIG_GPIO_MXC by default
> >
> > On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@....com>
> > wrote:
> > >
> > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> > > built-in manually.
> >
> > Maybe it should stay not enabled? Please explain in commit msg why it should
> > be enabled.
>
> The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic
> function of GPIO pin operations and IRQ operations, it is enabled by default previously
> with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly
> enabled in defconfig to make sure it does NOT break any existing functions, that is
> why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> built-in manually " in commit msg, it aims to NOT change any previous behaviors.

Sure, I was just saying that all this should be in commit msg. The
commit should explain why it is there in the Linux kernel.

Best regards,
Krzysztof