linux-kernel - Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66722607-31aa-47b3-8724-55e261139712@baylibre.com>
Date:   Wed, 16 Sep 2020 09:09:31 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     khilman@...libre.com, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG

On 15/09/2020 22:05, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@...libre.com> wrote:
> [...]
>> +&usb {
>> +       status = "okay";
>> +       dr_mode = "otg";
>> +       vbus-supply = <&usb_pwr>;
>> +};
>> +
>> +&usb2_phy1 {
>> +       phy-supply = <&vcc_5v>;
> out of curiosity: why do we need this phy-supply here?
> isn't the usb_pwr regulator as vbus-supply above enough?

Damn you're right !
Thanks for noticing.

Neil

> 
> 
> Best regards,
> Martin
>