linux-kernel - Re: [PATCHv2] perf kvm: add kvm-stat for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200916080051.GF604@jagdpanzerIV.localdomain>
Date:   Wed, 16 Sep 2020 17:00:51 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        John Garry <john.garry@...wei.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Suleiman Souhlal <suleiman@...gle.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv2] perf kvm: add kvm-stat for arm64

On (20/09/16 15:51), Leo Yan wrote:
> On Wed, Sep 16, 2020 at 09:44:04AM +0900, Sergey Senozhatsky wrote:
> > On (20/09/15 21:21), Leo Yan wrote:
> > > 
> > > Sorry if I miss anything for this.
> > > 
> > 
> > No, you are absolutely right! I should have looked more attentively.
> > 
> > Is "IL" good enough for a decoded reason
> > 
> >  	{ARM_EXCEPTION_IRQ,		"IRQ"		},	\
> >  	{ARM_EXCEPTION_EL1_SERROR,	"SERROR"	},	\
> >  	{ARM_EXCEPTION_TRAP,		"TRAP"		},	\
> > +	{ARM_EXCEPTION_IL,		"IL"		}, \
> >  	{ARM_EXCEPTION_HYP_GONE,	"HYP_GONE"	}
> > 
> > or should there be "ILLEGAL", or maybe something even better?
> > ILLEGAL_EXC, etc.
> 
> I personally think "ILLEGAL" is neat and clear :)

OK.

By the way, arch/arm64/kernel/traps.c has esr_class_str[] with
decoded exception names. Maybe I can reuse some.

	-ss