linux-kernel - Re: [PATCH] soundwire: Add generic bandwidth allocation algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02abf228-f331-61fb-d8f6-d1df4b2f54a3@perex.cz>
Date:   Wed, 16 Sep 2020 10:29:52 +0200
From:   Jaroslav Kysela <perex@...ex.cz>
To:     Bard Liao <yung-chuan.liao@...ux.intel.com>,
        alsa-devel@...a-project.org, vkoul@...nel.org
Cc:     vinod.koul@...aro.org, gregkh@...uxfoundation.org,
        ranjani.sridharan@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, hui.wang@...onical.com,
        srinivas.kandagatla@...aro.org, bard.liao@...el.com,
        jank@...ence.com, mengdong.lin@...el.com, sanyog.r.kale@...el.com,
        rander.wang@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soundwire: Add generic bandwidth allocation algorithm

Dne 09. 09. 20 v 8:26 Jaroslav Kysela napsal(a):
> Dne 08. 09. 20 v 15:15 Bard Liao napsal(a):
>> This algorithm computes bus parameters like clock frequency, frame
>> shape and port transport parameters based on active stream(s) running
>> on the bus.
>>
>> Developers can also implement their own .compute_params() callback for
>> specific resource management algorithm, and set if before calling
>> sdw_add_bus_master()
>>
>> Credits: this patch is based on an earlier internal contribution by
>> Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. All hard-coded
>> values were removed from the initial contribution to use BIOS
>> information instead.
>>
>> Signed-off-by: Bard Liao <yung-chuan.liao@...ux.intel.com>
>> ---
>>  drivers/soundwire/Kconfig                     |   5 +
>>  drivers/soundwire/Makefile                    |   3 +
>>  drivers/soundwire/bus.c                       |   6 +
>>  drivers/soundwire/bus.h                       |  46 +-
>>  .../soundwire/generic_bandwidth_allocation.c  | 427 ++++++++++++++++++
>>  drivers/soundwire/intel.c                     |   3 +
>>  drivers/soundwire/stream.c                    |  12 +
>>  include/linux/soundwire/sdw.h                 |   3 +
>>  8 files changed, 503 insertions(+), 2 deletions(-)
>>  create mode 100644 drivers/soundwire/generic_bandwidth_allocation.c
> 
> I did testing and I've not found any issues. The abstraction looks good.
> 
> Acked-by: Jaroslav Kysela <perex@...ex.cz>
> 

Vinod, ping.... This is the last patch which is missing to get the soundwire
audio working on some Intel hardware platforms (laptops) which are already on
the market.

				Thank you,
					Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.