linux-kernel - Re: [PATCH] nvmem: core: fix missing of_node_put() in of_nvmem_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Sep 2020 09:46:22 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Vadym Kochan <vadym.kochan@...ision.eu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: core: fix missing of_node_put() in
 of_nvmem_device_get()



On 15/09/2020 22:48, Vadym Kochan wrote:
> of_parse_phandle() returns device_node with incremented ref count
> which needs to be decremented by of_node_put() when device_node
> is not used.
> 
> Fixes: e2a5402ec7c6 ("nvmem: Add nvmem_device based consumer apis.")
> Signed-off-by: Vadym Kochan <vadym.kochan@...ision.eu>
> ---
>   drivers/nvmem/core.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)


Applied thanks,

--srini

> 
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 6cd3edb2eaf6..204a515d8bc5 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -835,6 +835,7 @@ struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id)
>   {
>   
>   	struct device_node *nvmem_np;
> +	struct nvmem_device *nvmem;
>   	int index = 0;
>   
>   	if (id)
> @@ -844,7 +845,9 @@ struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id)
>   	if (!nvmem_np)
>   		return ERR_PTR(-ENOENT);
>   
> -	return __nvmem_device_get(nvmem_np, device_match_of_node);
> +	nvmem = __nvmem_device_get(nvmem_np, device_match_of_node);
> +	of_node_put(nvmem_np);
> +	return nvmem;
>   }
>   EXPORT_SYMBOL_GPL(of_nvmem_device_get);
>   #endif
>