linux-kernel - RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR18MB2998601673B4F089021B2763D8210@BYAPR18MB2998.namprd18.prod.outlook.com>
Date:   Wed, 16 Sep 2020 09:15:48 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>
Subject: RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

> -----Original Message-----
> From: Qinglang Miao <miaoqinglang@...wei.com>
> Sent: Wednesday, September 16, 2020 11:52 AM
> To: Nilesh Javali <njavali@...vell.com>; Manish Rangankar
> <mrangankar@...vell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; James E.J. Bottomley
> <jejb@...ux.ibm.com>; Martin K. Petersen <martin.petersen@...cle.com>
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Qinglang Miao
> <miaoqinglang@...wei.com>
> Subject: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
> 
> External Email
> 
> ----------------------------------------------------------------------
> The mutex bnx2i_dev_lock is initialized statically. It is unnecessary to
> initialize by mutex_init().
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/scsi/bnx2i/bnx2i_init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 6018cdd17..2b3f0c104 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
>  	if (sq_size && !is_power_of_2(sq_size))
>  		sq_size = roundup_pow_of_two(sq_size);
> 
> -	mutex_init(&bnx2i_dev_lock);
> -
>  	bnx2i_scsi_xport_template =
>  			iscsi_register_transport(&bnx2i_iscsi_transport);
>  	if (!bnx2i_scsi_xport_template) {
> --

Thanks,
Acked-by: Manish Rangankar <mrangankar@...vell.com>