linux-kernel - Re: [PATCH v2 4/4] crypto: allwinner/sun8i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200916093309.GA11483@Red>
Date:   Wed, 16 Sep 2020 11:33:09 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Horia Geantă <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        Iuliana Prodan <iuliana.prodan@....com>
Subject: Re: [PATCH v2 4/4] crypto: allwinner/sun8i - Simplify with
 dev_err_probe()

On Thu, Sep 10, 2020 at 09:29:19PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Changes since v1:
> 1. None
> ---
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 9 +++------
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 9 +++------
>  2 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> index 138759dc8190..e3c62051c595 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
> @@ -573,12 +573,9 @@ static int sun8i_ce_probe(struct platform_device *pdev)
>  		return irq;
>  
>  	ce->reset = devm_reset_control_get(&pdev->dev, NULL);
> -	if (IS_ERR(ce->reset)) {
> -		if (PTR_ERR(ce->reset) == -EPROBE_DEFER)
> -			return PTR_ERR(ce->reset);
> -		dev_err(&pdev->dev, "No reset control found\n");
> -		return PTR_ERR(ce->reset);
> -	}
> +	if (IS_ERR(ce->reset))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(ce->reset),
> +				     "No reset control found\n");
>  
>  	mutex_init(&ce->mlock);
>  
> diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> index 9a23515783a6..576df8c8df51 100644
> --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> @@ -545,12 +545,9 @@ static int sun8i_ss_probe(struct platform_device *pdev)
>  		return irq;
>  
>  	ss->reset = devm_reset_control_get(&pdev->dev, NULL);
> -	if (IS_ERR(ss->reset)) {
> -		if (PTR_ERR(ss->reset) == -EPROBE_DEFER)
> -			return PTR_ERR(ss->reset);
> -		dev_err(&pdev->dev, "No reset control found\n");
> -		return PTR_ERR(ss->reset);
> -	}
> +	if (IS_ERR(ss->reset))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(ss->reset),
> +				     "No reset control found\n");
>  
>  	mutex_init(&ss->mlock);
>  
> -- 
> 2.17.1
> 

Hello

Acked-by: Corentin Labbe <clabbe.montjoie@...il.com>
Tested-by: Corentin Labbe <clabbe.montjoie@...il.com>

Thanks