linux-kernel - Re: [PATCH 4/8] x86/mce: Add _ASM_EXTABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200916095935.GD2643@zn.tnic>
Date:   Wed, 16 Sep 2020 11:59:35 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Tony Luck <tony.luck@...el.com>
Cc:     Youquan Song <youquan.song@...el.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] x86/mce: Add _ASM_EXTABLE_CPY for copy user access

On Tue, Sep 08, 2020 at 10:55:15AM -0700, Tony Luck wrote:
> diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h
> index cf503824529c..6ea141f91163 100644
> --- a/arch/x86/include/asm/mce.h
> +++ b/arch/x86/include/asm/mce.h
> @@ -137,6 +137,7 @@
>  #define	MCE_HANDLED_EDAC	BIT_ULL(4)
>  #define	MCE_HANDLED_MCELOG	BIT_ULL(5)
>  #define MCE_IN_KERNEL_RECOV	BIT_ULL(6)
> +#define MCE_IN_KERNEL_COPYIN	BIT_ULL(7)

That flag needs a comment explaining what it is. And you can do
MCE_IN_KERNEL_RECOV, while you're at it, there's a nice comment above
its use in do_machine_check which you could use.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette