lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Sep 2020 18:16:04 +0100 From: Al Viro <viro@...iv.linux.org.uk> To: Christoph Hellwig <hch@....de> Cc: Richard Henderson <rth@...ddle.net>, Ivan Kokshaysky <ink@...assic.park.msu.ru>, Matt Turner <mattst88@...il.com>, Trond Myklebust <trond.myklebust@...merspace.com>, Anna Schumaker <anna.schumaker@...app.com>, linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org Subject: Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code On Thu, Sep 17, 2020 at 10:22:33AM +0200, Christoph Hellwig wrote: > There is no reason the generic fs code should bother with NFS specific > binary mount data - lift the conversion into nfs4_parse_monolithic > instead. Considering the size of struct compat_nfs4_mount_data_v1... Do we really need to bother with that "copy in place, so we go through the fields backwards" logics? Just make that > +static void nfs4_compat_mount_data_conv(struct nfs4_mount_data *data) > +{ struct compat_nfs4_mount_data_v1 compat; compat = *(struct compat_nfs4_mount_data_v1 *)data; and copy the damnt thing without worrying about the field order...
Powered by blists - more mailing lists