linux-kernel - Re: [PATCH 1/8] ARM: dts: imx6qdl: Correct interrupt flags in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPeQ8ZV5H4KY3dTacggyNbWxZRJoyMYNwevmTVjZ+bmHfA@mail.gmail.com>
Date:   Thu, 17 Sep 2020 08:40:57 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Tim Harvey <tharvey@...eworks.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        Michal Simek <michal.simek@...inx.com>,
        Adam Ford <aford173@...il.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Anson Huang <Anson.Huang@....com>,
        Robin Gong <yibin.gong@....com>,
        Alifer Moraes <alifer.wsdm@...il.com>,
        Leonard Crestez <leonard.crestez@....com>,
        "Angus Ainslie (Purism)" <angus@...ea.ca>,
        Vitor Massaru Iha <vitor@...saru.org>,
        Kever Yang <kever.yang@...k-chips.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 1/8] ARM: dts: imx6qdl: Correct interrupt flags in examples

On Sun, 13 Sep 2020 at 04:32, Shawn Guo <shawnguo@...nel.org> wrote:
>
> Add Tim who is the board owner.
>
> On Tue, Sep 08, 2020 at 05:02:34PM +0200, Krzysztof Kozlowski wrote:
> > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> > These are simple defines so they could be used in DTS but they will not
> > have the same meaning:
> > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> > 2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING
> >
> > Correct the interrupt flags, assuming the author of the code wanted some
> > logical behavior behind the name "ACTIVE_xxx", this is:
> >   ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> The subject prefix could be a bit more specific, like 'ARM: dts:
> imx6qdl-gw5xxx'.  Also, I do not quite understand meaning of 'in
> examples' in subject.

That's my copy-paste error. I'll resend with a proper subject.

Best regards,
Krzysztof