[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200917071451.GA30367@kozik-lap>
Date: Thu, 17 Sep 2020 09:14:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Rob Herring <robh+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list@...adcom.com,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Palmer Dabbelt <palmer@...belt.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Chris Packham <chris.packham@...iedtelesis.co.nz>,
Anson Huang <Anson.Huang@....com>,
Sungbo Eo <mans0n@...ani.run>, Stefan Agner <stefan@...er.ch>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Magnus Damm <magnus.damm@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Yash Shah <yash.shah@...ive.com>,
Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-unisoc@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 2/8] dt-bindings: gpio: include common schema in GPIO
controllers
On Wed, Sep 16, 2020 at 06:22:44PM +0200, Krzysztof Kozlowski wrote:
> Include the common GPIO schema in GPIO controllers to be sure all common
> properties are properly validated.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/gpio-mxs.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/gpio-rda.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml | 1 +
> Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 +++
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 3 +++
> Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 3 +++
> 13 files changed, 37 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> index c213cb9ddb9f..1ac69b9c03f9 100644
> --- a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml
> @@ -13,6 +13,9 @@ description: |
> This controller is the Chip Common A GPIO present on a number of Broadcom
> switch ASICs with integrated SoCs.
>
> +allOf:
> + - $ref: gpio-common.yaml#
> +
> properties:
> compatible:
> const: brcm,iproc-gpio-cca
> diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> index de0b9b5f6a70..737756e081fb 100644
> --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> @@ -9,6 +9,9 @@ title: Freescale i.MX/MXC GPIO controller
> maintainers:
> - Anson Huang <Anson.Huang@....com>
>
> +allOf:
> + - $ref: gpio-common.yaml#
> +
> properties:
> compatible:
> oneOf:
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> index dfa1133f8c5e..7fc04ab35044 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> @@ -17,6 +17,9 @@ description: |
> GPIO ports share the same IO space with PIN controller, the GPIO node
> will be represented as sub-nodes of MXS pinctrl node.
>
> +allOf:
> + - $ref: gpio-common.yaml#
> +
I found something to fix - this one should go under patternProperties,
not here.
Best regards,
Krzysztof
Powered by blists - more mailing lists