linux-kernel - Re: [RESEND v2 4/4] venus: put dummy vote on video-mem path after last session release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160032758702.4188128.5484979798760048057@swboyd.mtv.corp.google.com>
Date:   Thu, 17 Sep 2020 00:26:27 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Mansur Alisha Shaik <mansur@...eaurora.org>,
        linux-media@...r.kernel.org, stanimir.varbanov@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        vgarodia@...eaurora.org,
        Mansur Alisha Shaik <mansur@...eaurora.org>
Subject: Re: [RESEND v2 4/4] venus: put dummy vote on video-mem path after last session release

Quoting Mansur Alisha Shaik (2020-09-16 18:26:03)
> As per current implementation, we are unvoting "videom-mem" path
> for last video session during vdec_session_release().
> While video playback when we try to suspend device, we see video clock
> warnings since votes are already removed during vdec_session_release().
> 
> corrected this by putting dummy vote on "video-mem" after last video
> session release and unvoting it during suspend.
> 
> Signed-off-by: Mansur Alisha Shaik <mansur@...eaurora.org>
> ---

Fixes tag? Should this be combined with an earlier change?

>  drivers/media/platform/qcom/venus/pm_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> index 57877ea..c0a3524 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -212,6 +212,9 @@ static int load_scale_bw(struct venus_core *core)
>         }
>         mutex_unlock(&core->lock);
>  
> +       if (!total_avg && !total_peak)
> +               total_avg = kbps_to_icc(1000);

Can you add a comment in the code here? Just guessing but something
like..

	/*
	 * Keep bandwidth enabled here so that vdec_session_release()
	 * can disable clks without clks getting stuck. We'll drop the
	 * bandwidth request when this device is suspended so this is a
	 * low value to keep things on but not high power until the
	 * device is powered down.
	 */

> +
>         dev_dbg(core->dev, VDBGL "total: avg_bw: %u, peak_bw: %u\n",
>                 total_avg, total_peak);
>