linux-kernel - Re: [Patch 1/2] cpufreq: tegra194: get consistent cpuinfo_cur

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81d2517d-6581-b491-c509-832fd1c0321e@nvidia.com>
Date:   Thu, 17 Sep 2020 09:36:21 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Sumit Gupta <sumitg@...dia.com>, <viresh.kumar@...aro.org>,
        <rjw@...ysocki.net>, <thierry.reding@...il.com>,
        <linux-pm@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <ksitaraman@...dia.com>, <bbasu@...dia.com>
Subject: Re: [Patch 1/2] cpufreq: tegra194: get consistent cpuinfo_cur_freq



On 16/09/2020 18:11, Sumit Gupta wrote:
> Frequency returned by 'cpuinfo_cur_freq' using counters is not fixed
> and keeps changing slightly. This change returns a consistent value
> from freq_table. If the reconstructed frequency has acceptable delta
> from the last written value, then return the frequency corresponding
> to the last written ndiv value from freq_table. Otherwise, print a
> warning and return the reconstructed freq.

We should include the Fixes tag here ...

Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver")

> 
> Signed-off-by: Sumit Gupta <sumitg@...dia.com>

Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>

Viresh, ideally we need to include this fix for v5.9. Do you need Sumit
to resend with the Fixes tag or are you happy to add?

Thanks
Jon

-- 
nvpublic