linux-kernel - Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cga1AFs=GAT8GttoA_fSxM70kvxFDj9xirEDL8GHGVvaQ@mail.gmail.com>
Date:   Thu, 17 Sep 2020 10:31:35 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id

On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa <jolsa@...hat.com> wrote:
>
> On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote:
> > @@ -478,19 +479,8 @@ static int perf_event__inject_buildid(struct perf_tool *tool,
> >       if (thread__find_map(thread, sample->cpumode, sample->ip, &al)) {
> >               if (!al.map->dso->hit) {
> >                       al.map->dso->hit = 1;
> > -                     if (map__load(al.map) >= 0) {
>
> nice, that might do some nice speedup, did you see any?

I've checked it but the speed up was tiny on my machine.
I guess it's because the machine was idle and had everything
in memory.  But I also found some more points to improve.
Will share the result in the next spin.

Thanks
Namhyung