linux-kernel - Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2009170938030.1492@www.lameter.com>
Date:   Thu, 17 Sep 2020 09:40:09 +0000 (UTC)
From:   Christopher Lameter <cl@...ux.com>
To:     Marco Elver <elver@...gle.com>
cc:     akpm@...ux-foundation.org, glider@...gle.com, hpa@...or.com,
        paulmck@...nel.org, andreyknvl@...gle.com, aryabinin@...tuozzo.com,
        luto@...nel.org, bp@...en8.de, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, rientjes@...gle.com,
        dvyukov@...gle.com, edumazet@...gle.com,
        gregkh@...uxfoundation.org, mingo@...hat.com, jannh@...gle.com,
        Jonathan.Cameron@...wei.com, corbet@....net,
        iamjoonsoo.kim@....com, keescook@...omium.org,
        mark.rutland@....com, penberg@...nel.org, peterz@...radead.org,
        cai@....pw, tglx@...utronix.de, vbabka@...e.cz, will@...nel.org,
        x86@...nel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-arm-kernel@...ts.infradead.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB

On Tue, 15 Sep 2020, Marco Elver wrote:

>  void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
>  {
> -	void *ret = slab_alloc(s, gfpflags, _RET_IP_);
> +	void *ret = slab_alloc(s, gfpflags, _RET_IP_, s->object_size);

The additional size parameter is a part of a struct kmem_cache that is
already passed to the function. Why does the parameter list need to be
expanded?