linux-kernel - Re: [PATCHv3] perf kvm: add kvm-stat for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200917095450.GA3049@jagdpanzerIV.localdomain>
Date:   Thu, 17 Sep 2020 18:54:50 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        John Garry <john.garry@...wei.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Suleiman Souhlal <suleiman@...gle.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64

On (20/09/17 16:47), Leo Yan wrote:
[..]
> > +static void event_get_key(struct evsel *evsel,
> > +			  struct perf_sample *sample,
> > +			  struct event_key *key)
> > +{
> > +	key->info = 0;
> > +	key->key = perf_evsel__intval(evsel, sample, kvm_exit_reason);
> 
> Now the perf/core branch doesn't have API perf_evsel__intval(), and it
> has been replaced with evsel__intval(); so please
> 
> s/perf_evsel__intval/evsel__intval

ACK.
The kernel I'm using still have perf_evsel__intval().

> > +	if (key->key == ARM_EXCEPTION_TRAP) {
> > +		key->key = perf_evsel__intval(evsel, sample,
> 
> Ditto.

ACK. Sorry about that.

> Otherwise, this patch is good for me and I have tested this patch with
> below commands:
> 
>   $ perf kvm stat record
>   $ perf kvm stat report

"perf kvm stat live" should also work.

> Reviewed-by: Leo Yan <leo.yan@...aro.org>
> Tested-by: Leo Yan <leo.yan@...aro.org>

Thanks!

	-ss