linux-kernel - Re: [PATCH] lib: kunit: add bitfield test conversion to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfcb01c087fdd9f22a875721444a7659bceec05f.camel@sipsolutions.net>
Date:   Thu, 17 Sep 2020 12:00:12 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Brendan Higgins <brendanhiggins@...gle.com>,
        Vitor Massaru Iha <vitor@...saru.org>
Cc:     KUnit Development <kunit-dev@...glegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        kvalo@...eaurora.org
Subject: Re: [PATCH] lib: kunit: add bitfield test conversion to KUnit

On Wed, 2020-08-19 at 14:10 -0700, Brendan Higgins wrote:
> On Wed, Jul 29, 2020 at 10:58 AM Vitor Massaru Iha <vitor@...saru.org> wrote:
> > This adds the conversion of the runtime tests of test_bitfield,
> > from `lib/test_bitfield.c` to KUnit tests.
> > 
> > Please apply this commit first (linux-kselftest/kunit-fixes):
> > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space
> > 
> > Code Style Documentation: [0]
> > 
> > Signed-off-by: Vitor Massaru Iha <vitor@...saru.org>
> > Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/T/#u
> 
> Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>
> 
> Probably still want a review from Johannes though.

Huh, sorry, this slipped through the cracks.

Yeah, don't really care, looks fine to me? I'm not familiar with the
kunit infrastructure much yet.

Not sure I see much value in converting TEST_BITFIELD_COMPILE to a
KUNIT_CASE though, because anyway it will not compile if you enable
that? IOW, just leaving the function there without any KUNIT_CASE()
reference to it should be fine and saves you an ifdef ...

johannes