linux-kernel - Re: [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <132c32b9-b68a-8da9-310e-c85fe17be83e@arm.com>
Date:   Thu, 17 Sep 2020 11:29:09 +0100
From:   Steven Price <steven.price@....com>
To:     Neil Armstrong <narmstrong@...libre.com>, robh@...nel.org,
        tomeu.vizoso@...labora.com, alyssa.rosenzweig@...labora.com
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks

On 16/09/2020 16:01, Neil Armstrong wrote:
> This adds the required GPU quirks, including the quirk in the PWR registers at the GPU
> reset time and the IOMMU quirk for shareability issues observed on G52 in Amlogic G12B SoCs.
> 
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>

Reviewed-by: Steven Price <steven.price@....com>

> ---
>   drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7c8a87d164c3..6e5dedacb777 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -658,7 +658,18 @@ static const struct panfrost_compatible default_data = {
>   	.pm_domain_names = NULL,
>   };
>   
> +static const struct panfrost_compatible amlogic_data = {
> +	.num_supplies = ARRAY_SIZE(default_supplies),
> +	.supply_names = default_supplies,
> +	.vendor_quirk = panfrost_gpu_amlogic_quirk,
> +};
> +
>   static const struct of_device_id dt_match[] = {
> +	/* Set first to probe before the generic compatibles */
> +	{ .compatible = "amlogic,meson-gxm-mali",
> +	  .data = &amlogic_data, },
> +	{ .compatible = "amlogic,meson-g12a-mali",
> +	  .data = &amlogic_data, },
>   	{ .compatible = "arm,mali-t604", .data = &default_data, },
>   	{ .compatible = "arm,mali-t624", .data = &default_data, },
>   	{ .compatible = "arm,mali-t628", .data = &default_data, },
>