[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200917111940.GA12912@Asurada-Nvidia>
Date: Thu, 17 Sep 2020 04:19:41 -0700
From: Nicolin Chen <nicoleotsuka@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Thierry Reding <thierry.reding@...il.com>,
Joerg Roedel <joro@...tes.org>, linux-tegra@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
jonathanh@...dia.com
Subject: Re: [PATCH] memory: tegra: Correct num_tlb_lines for tegra210
On Thu, Sep 17, 2020 at 12:54:42PM +0200, Krzysztof Kozlowski wrote:
> On Thu, 17 Sep 2020 at 12:43, Thierry Reding <thierry.reding@...il.com> wrote:
> >
> > On Tue, Sep 15, 2020 at 04:28:03PM -0700, Nicolin Chen wrote:
> > > According to Tegra210 TRM, the default value of TLB_ACTIVE_LINES
> > > field of register MC_SMMU_TLB_CONFIG_0 is 0x30. So num_tlb_lines
> > > should be 48 (0x30) rather than 32 (0x20).
> > >
> > > Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> > > ---
> > > drivers/memory/tegra/tegra210.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Please send this as part of a series including:
> >
> > https://patchwork.ozlabs.org/project/linux-tegra/patch/20200916002359.10823-1-nicoleotsuka@gmail.com/
> >
> > Adding Joerg for visibility. From the Tegra side:
> >
> > Acked-by: Thierry Reding <treding@...dia.com>
>
> So basically applying this one alone breaks existing platforms and
> makes history non-bisectable...
>
> Nicolin, the bisectability is important requirement so you must always
> mention the dependencies between patches.
Sorry. Will be careful next time.
And I am resending both in a series.
Thanks
Nic
Powered by blists - more mailing lists