linux-kernel - Re: [PATCH] mm: avoid possible multiple call to swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200917114824.GS5449@casper.infradead.org>
Date:   Thu, 17 Sep 2020 12:48:24 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: avoid possible multiple call to swap_node()

On Thu, Sep 17, 2020 at 07:44:49AM -0400, Miaohe Lin wrote:
> Cache the swap_node() in a local variable to avoid possible multiple call
> to swap_node(), though compiler may do this for us.

Why don't you find out?  Compare the assembly before and after, see what
the compiler did.