linux-kernel - Re: [PATCH] platform/x86: fix kconfig dependency warning for LG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Sep 2020 14:16:17 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>, andy@...radead.org
Cc:     matan@...alib.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] platform/x86: fix kconfig dependency warning for
 LG_LAPTOP

Hi,

On 9/15/20 11:09 AM, Necip Fazil Yildiran wrote:
> When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for LEDS_CLASS
>    Depends on [n]: NEW_LEDS [=n]
>    Selected by [y]:
>    - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y]
> 
> The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
> selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>

Thnak you, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Note it seems that the FUJITSU_LAPTOP Kconfig symbol has the same
issue, can you submit a patch for that one too?

Regards,

Hans

> ---
>   drivers/platform/x86/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..81f6079d08e6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1112,6 +1112,7 @@ config LG_LAPTOP
>   	depends on ACPI_WMI
>   	depends on INPUT
>   	select INPUT_SPARSEKMAP
> +	select NEW_LEDS
>   	select LEDS_CLASS
>   	help
>   	 This driver adds support for hotkeys as well as control of keyboard
>