linux-kernel - Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200917123806.GA114613@nvidia.com>
Date:   Thu, 17 Sep 2020 09:38:06 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Liu Shixin <liushixin2@...wei.com>,
        Doug Ledford <dledford@...hat.com>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in
 __mlx5_ib_alloc_counters()

On Thu, Sep 17, 2020 at 12:08:10PM +0300, Leon Romanovsky wrote:
> On Thu, Sep 17, 2020 at 05:10:08PM +0800, Liu Shixin wrote:
> > sizeof() when applied to a pointer typed expression should give the
> > size of the pointed data, even if the data is a pointer.
> >
> > Signed-off-by: Liu Shixin <liushixin2@...wei.com>

Needs a fixes line

> >  	if (!cnts->names)
> >  		return -ENOMEM;
> >
> >  	cnts->offsets = kcalloc(num_counters,
> > -				sizeof(cnts->offsets), GFP_KERNEL);
> > +				sizeof(*cnts->offsets), GFP_KERNEL);
> 
> This is not.

Why not?

Jason