linux-kernel - Re: [PATCH v6 0/7] perf: Stream comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bf033e6-56a0-ea20-c46c-364b51952fef@linux.intel.com>
Date:   Fri, 18 Sep 2020 14:54:55 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v6 0/7] perf: Stream comparison

Hi Arnaldo,

On 9/18/2020 4:13 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Sep 17, 2020 at 03:05:56PM +0200, Jiri Olsa escreveu:
>> On Fri, Sep 11, 2020 at 04:03:46PM +0800, Jin Yao wrote:
>>
>> SNIP
>>
>>>                        main div.c:40
>>>                        main div.c:40
>>>                        main div.c:39
>>>
>>> [ Hot streams in new perf data only ]
>>>
>>> hot chain 1:
>>>                                                       cycles: 4, hits: 4.54%
>>>                                                   --------------------------
>>>                                                                main div.c:42
>>>                                                        compute_flag div.c:28
>>>
>>> hot chain 2:
>>>                                                       cycles: 5, hits: 3.51%
>>>                                                   --------------------------
>>>                                                                main div.c:39
>>>                                                                main div.c:44
>>>                                                                main div.c:42
>>>                                                        compute_flag div.c:28
>>>
>>>   v6:
>>>   ---
>>>   Rebase to perf/core
>>
>> it looks good to me
>>
>> Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Jin,
> 
> 	I'm sorry I only got to look at this now, there are some issues,
> I'll try to point them out patch by patch,
> 
> Thanks,
> 
> - Arnaldo
> 

Thanks so much for looking at this patchset! :)

I will fix the issues which you point out in other mail threads. Once the fixes are done, I will 
post v7.

Thanks
Jin Yao