linux-kernel - Re: [PATCH 3/3] crypto: hisilicon/hpre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918071112.GA9883@gondor.apana.org.au>
Date:   Fri, 18 Sep 2020 17:11:12 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Meng Yu <yumeng18@...wei.com>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        xuzaibo@...wei.com, wangzhou1@...ilicon.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm

On Thu, Sep 10, 2020 at 07:25:22PM +0800, Meng Yu wrote:
>
> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> index 0cbe99a1..2d91593 100644
> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> @@ -528,6 +528,8 @@ static int hpre_dh_compute_value(struct kpp_request *req)
>  		ret = hpre_hw_data_init(hpre_req, req->src, req->src_len, 1, 1);
>  		if (unlikely(ret))
>  			goto clear_all;
> +	} else {
> +		msg->in = cpu_to_le64((u64)ctx->dh.dma_g);

Why do you need the u64 cast?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt