linux-kernel - RE: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence MHDP8546 bridge bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR07MB61541CC71AC926948802B753C53F0@DM6PR07MB6154.namprd07.prod.outlook.com>
Date:   Fri, 18 Sep 2020 07:27:23 +0000
From:   Swapnil Kashinath Jakhade <sjakhade@...ence.com>
To:     Tomi Valkeinen <tomi.valkeinen@...com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "a.hajda@...sung.com" <a.hajda@...sung.com>,
        "narmstrong@...libre.com" <narmstrong@...libre.com>,
        "jonas@...boo.se" <jonas@...boo.se>,
        "jernej.skrabec@...l.net" <jernej.skrabec@...l.net>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Milind Parab <mparab@...ence.com>,
        Yuti Suresh Amonkar <yamonkar@...ence.com>,
        "jsarha@...com" <jsarha@...com>, "nsekhar@...com" <nsekhar@...com>,
        "praneeth@...com" <praneeth@...com>,
        "nikhil.nd@...com" <nikhil.nd@...com>
Subject: RE: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence
 MHDP8546 bridge bindings

Hi Tomi,

> -----Original Message-----
> From: Tomi Valkeinen <tomi.valkeinen@...com>
> Sent: Wednesday, September 16, 2020 5:48 PM
> To: Swapnil Kashinath Jakhade <sjakhade@...ence.com>; airlied@...ux.ie;
> daniel@...ll.ch; Laurent.pinchart@...asonboard.com; robh+dt@...nel.org;
> a.hajda@...sung.com; narmstrong@...libre.com; jonas@...boo.se;
> jernej.skrabec@...l.net; dri-devel@...ts.freedesktop.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Milind Parab <mparab@...ence.com>; Yuti Suresh Amonkar
> <yamonkar@...ence.com>; jsarha@...com; nsekhar@...com;
> praneeth@...com; nikhil.nd@...com
> Subject: Re: [PATCH v10 1/3] dt-bindings: drm/bridge: Document Cadence
> MHDP8546 bridge bindings
> 
> EXTERNAL MAIL
> 
> 
> Hi Swapnil, Yuti,
> 
> On 14/09/2020 15:48, Swapnil Jakhade wrote:
> > From: Yuti Amonkar <yamonkar@...ence.com>
> >
> > Document the bindings used for the Cadence MHDP8546 DPI/DP bridge in
> > yaml format.
> >
> > Signed-off-by: Yuti Amonkar <yamonkar@...ence.com>
> > Signed-off-by: Swapnil Jakhade <sjakhade@...ence.com>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > ---
> >  .../display/bridge/cdns,mhdp8546.yaml         | 154 ++++++++++++++++++
> >  1 file changed, 154 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> I was testing this on J7 EVM, and looking at the dts files and DT bindings. To
> get rid of the warnings from dtbs_check, I made the following changes.
> 
> I think the interrupt one is clear. The driver needs the interrupt, but it was
> not defined in the yaml file.
> 
> For phy-names, we had that in the out-of-tree dts file, so I added it here. The
> driver just looks for the PHY via index, but I guess we should require it.
> 
> The power-domain is not needed by the driver, but if I'm not mistaken, has
> to be defined here.
> 
> 
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> index a21a4bfe15cf..c5f5781c1ed6 100644
> ---
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> +++
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yam
> +++ l
> @@ -46,6 +46,16 @@ properties:
>      description:
>        phandle to the DisplayPort PHY.
> 
> +  phy-names:
> +    items:
> +      - const: dpphy
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
>    ports:
>      type: object
>      description:
> @@ -114,6 +124,8 @@ required:
>    - reg
>    - reg-names
>    - phys
> +  - phy-names
> +  - interrupts
>    - ports
> 

Okay. We will update the bindings as per above suggestions. Thanks for your inputs.

Thanks & regards,
Swapnil

>  additionalProperties: false
> 
>  Tomi
> 
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki