linux-kernel - Re: [PATCH v2] dmaengine: ti: k3-udma-glue: fix channel enable functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200918073643.GM2968@vkoul-mobl>
Date:   Fri, 18 Sep 2020 13:06:43 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>, dmaengine@...r.kernel.org,
        Sekhar Nori <nsekhar@...com>, linux-kernel@...r.kernel.org,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v2] dmaengine: ti: k3-udma-glue: fix channel enable
 functions

On 16-09-20, 15:09, Grygorii Strashko wrote:
> Now the K3 UDMA glue layer enable functions perform RMW operation on UDMA
> RX/TX RT_CTL registers to set EN bit and enable channel, which is
> incorrect, because only EN bit has to be set in those registers to enable
> channel (all other bits should be cleared 0).
> More over, this causes issues when bootloader leaves UDMA channel RX/TX
> RT_CTL registers in incorrect state - TDOWN bit set, for example. As
> result, UDMA channel will just perform teardown right after it's enabled.
> 
> Hence, fix it by writing correct values (EN=1) directly in UDMA channel
> RX/TX RT_CTL registers in k3_udma_glue_enable_tx/rx_chn() functions.

Applied, thanks

-- 
~Vinod