linux-kernel - Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918183717.7d25a71d@canb.auug.org.au>
Date:   Fri, 18 Sep 2020 18:37:17 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)

Hi Randy,

On Thu, 17 Sep 2020 13:45:52 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Maybe some older versions of gcc just can't handle IS_ENABLED() inside an
> if (expression) very well.
> 
> > gcc --version  
> gcc (SUSE Linux) 7.5.0
> 
> This patch:
> 
> commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
> Author: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Date:   Wed May 13 15:58:43 2020 +0200
> 
>     netns: enable to inherit devconf from current netns
> 
> causes a build error:
> 
> ../net/ipv4/devinet.c: In function ‘devinet_init_net’:
> ../net/ipv4/devinet.c:2672:7: error: ‘sysctl_devconf_inherit_init_net’ undeclared (first use in this function); did you mean ‘devinet_init_net’?
>        sysctl_devconf_inherit_init_net == 3) {
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        devinet_init_net
> ../net/ipv4/devinet.c:2672:7: note: each undeclared identifier is reported only

With your config, can you try creating net/ipv4/devinet.i (preprocessed) file and
see if sysctl_devconf_inherit_init_net is actually declared?  I
couldn't see any obvious way it is not, but that would explain the
error.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped