linux-kernel - Re: [PATCH v2 33/37] kasan, arm64: implement HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeHK+zxJqQ3v_K7UkMMMrz73+3LQwZctDGngrJabXtiXU5YvA@mail.gmail.com>
Date:   Fri, 18 Sep 2020 14:28:11 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Marco Elver <elver@...gle.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Elena Petrova <lenaptr@...gle.com>,
        Branislav Rankov <Branislav.Rankov@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Will Deacon <will.deacon@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime

On Fri, Sep 18, 2020 at 12:46 PM Marco Elver <elver@...gle.com> wrote:
>
> On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
> [...]
> >  arch/arm64/include/asm/memory.h   |  4 +-
> >  arch/arm64/kernel/setup.c         |  1 -
> >  include/linux/kasan.h             |  6 +--
> >  include/linux/mm.h                |  2 +-
> >  include/linux/page-flags-layout.h |  2 +-
> >  mm/kasan/Makefile                 |  5 ++
> >  mm/kasan/common.c                 | 14 +++---
> >  mm/kasan/kasan.h                  | 17 +++++--
> >  mm/kasan/report_tags_hw.c         | 47 +++++++++++++++++++
> >  mm/kasan/report_tags_sw.c         |  2 +-
> >  mm/kasan/shadow.c                 |  2 +-
> >  mm/kasan/tags_hw.c                | 78 +++++++++++++++++++++++++++++++
> >  mm/kasan/tags_sw.c                |  2 +-
> >  13 files changed, 162 insertions(+), 20 deletions(-)
> >  create mode 100644 mm/kasan/report_tags_hw.c
> >  create mode 100644 mm/kasan/tags_hw.c
> [...]
> > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > index 77c4c9bad1b8..5985be8af2c6 100644
> > --- a/arch/arm64/kernel/setup.c
> > +++ b/arch/arm64/kernel/setup.c
> > @@ -358,7 +358,6 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
> >       smp_init_cpus();
> >       smp_build_mpidr_hash();
> >
> > -     /* Init percpu seeds for random tags after cpus are set up. */
>
> Why was the comment removed and not updated?

Will fix in v3, thanks!