linux-kernel - Re: canfdtest on flexcan loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Sep 2020 14:35:59 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        Pankaj Bansal <pankaj.bansal@....com>,
        "Pankaj Bansal (OSS)" <pankaj.bansal@....nxp.com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: canfdtest on flexcan loopback

On 9/18/20 2:27 PM, Vladimir Oltean wrote:
>> Is there a bug in v5.4.3? v5.4.66 is current latest v5.4.x

> commit 63d5320a0c9b9867628a3a5a12e7f11d4cc109c2
> Author: Paolo Abeni <pabeni@...hat.com>
> Date:   Tue Feb 18 18:15:44 2020 +0100
> 
>     Revert "net: dev: introduce support for sch BYPASS for lockless qdisc"
> 
>     [ Upstream commit 379349e9bc3b42b8b2f8f7a03f64a97623fff323 ]
> 
>     This reverts commit ba27b4cdaaa66561aaedb2101876e563738d36fe
> 
>     Ahmed reported ouf-of-order issues bisected to commit ba27b4cdaaa6

yes, that's probably the the issue.

This concluded into using an old LTS kernel, is worse than using the latest
kernel :)

>     ("net: dev: introduce support for sch BYPASS for lockless qdisc").
>     I can't find any working solution other than a plain revert.
> 
>     This will introduce some minor performance regressions for
>     pfifo_fast qdisc. I plan to address them in net-next with more
>     indirect call wrapper boilerplate for qdiscs.
> 
>     Reported-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
>     Fixes: ba27b4cdaaa6 ("net: dev: introduce support for sch BYPASS for lockless qdisc")
>     Signed-off-by: Paolo Abeni <pabeni@...hat.com>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
>  net/core/dev.c | 22 ++--------------------
>  1 file changed, 2 insertions(+), 20 deletions(-)

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)