lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Sep 2020 14:43:46 +0200 From: Daniel Vetter <daniel@...ll.ch> To: Jing Xiangfeng <jingxiangfeng@...wei.com> Cc: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, b.zolnierkie@...sung.com, gregkh@...uxfoundation.org, daniel.vetter@...ll.ch, jirislaby@...nel.org, ndesaulniers@...gle.com, natechancellor@...il.com, george.kennedy@...cle.com, peda@...ntia.se, dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fbcon: Remove the superfluous break On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote: > > > On 2020/9/18 2:52, Gustavo A. R. Silva wrote: > > > > > > On 9/17/20 08:15, Jing Xiangfeng wrote: > > > Remove the superfuous break, as there is a 'return' before it. > > > > > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com> > > > > Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org> > > > > Also, the following Fixes tag should be included in the changelog text: > > > > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") > > OK, I'll send a v2 with this tag. Please also collect all the r-b tags you received so I can just apply everything. -Daniel > > > > > Thanks > > -- > > Gustavo > > > > > --- > > > drivers/video/fbdev/core/fbcon.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > > > index 0b49b0f44edf..623359aadd1e 100644 > > > --- a/drivers/video/fbdev/core/fbcon.c > > > +++ b/drivers/video/fbdev/core/fbcon.c > > > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > > > vc->vc_video_erase_char, > > > vc->vc_size_row * count); > > > return true; > > > - break; > > > > > > case SCROLL_WRAP_MOVE: > > > if (b - t - count > 3 * vc->vc_rows >> 2) { > > > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > > > vc->vc_video_erase_char, > > > vc->vc_size_row * count); > > > return true; > > > - break; > > > > > > case SCROLL_WRAP_MOVE: > > > if (b - t - count > 3 * vc->vc_rows >> 2) { > > > > > . > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists