[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200918133202.GH5703@sirena.org.uk>
Date: Fri, 18 Sep 2020 14:32:02 +0100
From: Mark Brown <broonie@...nel.org>
To: Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] ASoC: fix kconfig dependency warnings for SND_SOC_WM8731
On Fri, Sep 18, 2020 at 04:12:58PM +0300, Necip Fazil Yildiran wrote:
> SND_SOC_WM8731 was made visible and dependent on other symbols with commit
> 1291e14175e6 ("ASoC: codecs: Make OF supported CODECs visible in Kconfig").
> To this respect, the symbols selecting SND_SOC_WM8731 turned out to be
> overlooking its dependencies.
> Switch reverse dependencies on SND_SOC_WM8731 to normal dependencies.
No, this is very user hostile - users shouldn't have to know exactly
which chips a given machine driver needs to figure out how to get the
config option visible. Please fix the selects in the machine driver
instead.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists