linux-kernel - Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Sep 2020 17:20:26 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Serge Semin <fancer.lancer@...il.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Lee Jones <lee.jones@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Andreas Färber <afaerber@...e.de>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Anson Huang <Anson.Huang@....com>,
        Sungbo Eo <mans0n@...ani.run>, Stefan Agner <stefan@...er.ch>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Magnus Damm <magnus.damm@...il.com>,
        Yash Shah <yash.shah@...ive.com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        - <patches@...nsource.cirrus.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Amelie Delaunay <amelie.delaunay@...com>,
        Cristian Ciocaltea <cristian.ciocaltea@...il.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Andy Teng <andy.teng@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Sricharan R <sricharan@...eaurora.org>,
        Chris Brandt <chris.brandt@...esas.com>,
        Jaroslav Kysela <perex@...ex.cz>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in
 GPIO controllers

Hi Krzysztof,

On Fri, Sep 18, 2020 at 10:19:25AM +0200, Krzysztof Kozlowski wrote:
> On Thu, 17 Sep 2020 at 22:12, Laurent Pinchart wrote:
> > On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote:
> > > Include the common GPIO schema in GPIO controllers to be sure all common
> > > properties are properly validated.
> >
> > Shouldn't we delete the properties that are now redundant from these
> > schemas ?
> 
> Good point. However not with "additionalPropeties: false". Schema
> requires all properties to be mentioned. I would need to use
> "unevaluatedProperties: false" in each file.
> 
> What is preferred?

I've seen Rob advocating for unevaluatedProperties multiple times, but
I'll let him comment on this, I don't want to speak for him.

-- 
Regards,

Laurent Pinchart