linux-kernel - Re: [PATCH net-next] net: brcmfmac: check return value of driver_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lfh7b103.fsf@codeaurora.org>
Date:   Fri, 18 Sep 2020 17:41:48 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next] net: brcmfmac: check return value of driver_for_each_device()

+ linux-wireless

Zhang Changzhong <zhangchangzhong@...wei.com> writes:

> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
>  variable 'ret' set but not used [-Wunused-but-set-variable]
>   1576 |  int ret;
>        |      ^~~
>
> driver_for_each_device() has been declared with __must_check, so the
> return value should be checked.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Please cc linux-wireless on all wireless patches. Otherwise our
patchwork won't see it and I can't apply it. So please resend as v2.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches