linux-kernel - Re: [PATCH] scsi: arcmsr: Remove the superfluous break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918145619.GA25599@embeddedor>
Date:   Fri, 18 Sep 2020 09:56:19 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        lee.jones@...aro.org, colin.king@...onical.com, axboe@...nel.dk,
        mchehab+huawei@...nel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break

On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
> Remove the superfluous break, as there is a 'return' before it.
>

Apparently, the change is correct. Please, just add a proper Fixes tag by
yourself this time.

Thanks
--
Gustavo

> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>  drivers/scsi/arcmsr/arcmsr_hba.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index ec895d0319f0..74add6d247d5 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -2699,10 +2699,8 @@ static irqreturn_t arcmsr_interrupt(struct AdapterControlBlock *acb)
>  	switch (acb->adapter_type) {
>  	case ACB_ADAPTER_TYPE_A:
>  		return arcmsr_hbaA_handle_isr(acb);
> -		break;
>  	case ACB_ADAPTER_TYPE_B:
>  		return arcmsr_hbaB_handle_isr(acb);
> -		break;
>  	case ACB_ADAPTER_TYPE_C:
>  		return arcmsr_hbaC_handle_isr(acb);
>  	case ACB_ADAPTER_TYPE_D:
> -- 
> 2.17.1
>