linux-kernel - Re: [PATCH] ocxl: fix kconfig dependency warning for OCXL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1142ed3-c769-f906-3780-8b68c783b565@linux.ibm.com>
Date:   Fri, 18 Sep 2020 17:12:26 +0200
From:   Frederic Barrat <fbarrat@...ux.ibm.com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc:     mpe@...erman.id.au, gregkh@...uxfoundation.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] ocxl: fix kconfig dependency warning for OCXL



Le 18/09/2020 à 11:41, Necip Fazil Yildiran a écrit :
> When OCXL is enabled and HOTPLUG_PCI is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for HOTPLUG_PCI_POWERNV
>    Depends on [n]: PCI [=y] && HOTPLUG_PCI [=n] && PPC_POWERNV [=y] && EEH [=y]
>    Selected by [y]:
>    - OCXL [=y] && PPC_POWERNV [=y] && PCI [=y] && EEH [=y]
> 
> The reason is that OCXL selects HOTPLUG_PCI_POWERNV without depending on
> or selecting HOTPLUG_PCI while HOTPLUG_PCI_POWERNV is subordinate to
> HOTPLUG_PCI.
> 
> HOTPLUG_PCI_POWERNV is a visible symbol with a set of dependencies.
> Selecting it will lead to overlooking its other dependencies as well.
> 
> Let OCXL depend on HOTPLUG_PCI_POWERNV instead to avoid Kbuild issues.
> 
> Fixes: 49ce94b8677c ("ocxl: Add PCI hotplug dependency to Kconfig")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
> ---

OK, that makes sense, thanks!
Acked-by: Frederic Barrat <fbarrat@...ux.ibm.com>



>   drivers/misc/ocxl/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig
> index 6551007a066c..947294f6d7f4 100644
> --- a/drivers/misc/ocxl/Kconfig
> +++ b/drivers/misc/ocxl/Kconfig
> @@ -9,9 +9,8 @@ config OCXL_BASE
>   
>   config OCXL
>   	tristate "OpenCAPI coherent accelerator support"
> -	depends on PPC_POWERNV && PCI && EEH
> +	depends on PPC_POWERNV && PCI && EEH && HOTPLUG_PCI_POWERNV
>   	select OCXL_BASE
> -	select HOTPLUG_PCI_POWERNV
>   	default m
>   	help
>   	  Select this option to enable the ocxl driver for Open
>