linux-kernel - Re: [PATCH v3] ptp: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Sep 2020 23:21:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Herrington <hankinsea@...il.com>,
        Richard Cochran <richardcochran@...il.com>
Cc:     kbuild-all@...ts.01.org, leonro@...dia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, hankinsea@...il.com
Subject: Re: [PATCH v3] ptp: mark symbols static where possible

Hi Herrington,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc5 next-20200918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Herrington/ptp-mark-symbols-static-where-possible/20200918-181139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 10b82d5176488acee2820e5a2cf0f2ec5c3488b6
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:12:
>> include/linux/ptp_clock_kernel.h:310:34: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     310 | void pch_ch_control_write(struct pci_dev *pdev, u32 val);
         |                                  ^~~~~~~
   include/linux/ptp_clock_kernel.h:311:30: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     311 | u32 pch_ch_event_read(struct pci_dev *pdev);
         |                              ^~~~~~~
   include/linux/ptp_clock_kernel.h:312:32: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     312 | void pch_ch_event_write(struct pci_dev *pdev, u32 val);
         |                                ^~~~~~~
   include/linux/ptp_clock_kernel.h:313:33: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     313 | u32 pch_src_uuid_lo_read(struct pci_dev *pdev);
         |                                 ^~~~~~~
   include/linux/ptp_clock_kernel.h:314:33: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     314 | u32 pch_src_uuid_hi_read(struct pci_dev *pdev);
         |                                 ^~~~~~~
   include/linux/ptp_clock_kernel.h:315:29: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     315 | u64 pch_rx_snap_read(struct pci_dev *pdev);
         |                             ^~~~~~~
   include/linux/ptp_clock_kernel.h:316:29: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     316 | u64 pch_tx_snap_read(struct pci_dev *pdev);
         |                             ^~~~~~~
   include/linux/ptp_clock_kernel.h:317:46: warning: 'struct pci_dev' declared inside parameter list will not be visible outside of this definition or declaration
     317 | int pch_set_station_address(u8 *addr, struct pci_dev *pdev);
         |                                              ^~~~~~~

# https://github.com/0day-ci/linux/commit/d5fd7587ec0ce30118654a4b5c38a41a19ea5920
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Herrington/ptp-mark-symbols-static-where-possible/20200918-181139
git checkout d5fd7587ec0ce30118654a4b5c38a41a19ea5920
vim +310 include/linux/ptp_clock_kernel.h

   309	
 > 310	void pch_ch_control_write(struct pci_dev *pdev, u32 val);
   311	u32 pch_ch_event_read(struct pci_dev *pdev);
   312	void pch_ch_event_write(struct pci_dev *pdev, u32 val);
   313	u32 pch_src_uuid_lo_read(struct pci_dev *pdev);
   314	u32 pch_src_uuid_hi_read(struct pci_dev *pdev);
   315	u64 pch_rx_snap_read(struct pci_dev *pdev);
   316	u64 pch_tx_snap_read(struct pci_dev *pdev);
   317	int pch_set_station_address(u8 *addr, struct pci_dev *pdev);
   318	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65335 bytes)